This repository has been archived by the owner on Jun 21, 2024. It is now read-only.
cleanup and upgrade deps #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
commented
Apr 15, 2024
| @@ -38,6 +38,7 @@ use crate::{ | |||
| compression | |||
| ) | |||
| )] | |||
| #[debug_handler] | |||
There was a problem hiding this comment.
shows more informative compiler errors. Allowed me to pinpoint that the issue was InsecureClientIp needed an upgrade
There was a problem hiding this comment.
This macro has no effect when compiled with the release profile.
Nice
bretthoerner
approved these changes
Apr 15, 2024
| @@ -38,6 +38,7 @@ use crate::{ | |||
| compression | |||
| ) | |||
| )] | |||
| #[debug_handler] | |||
There was a problem hiding this comment.
This macro has no effect when compiled with the release profile.
Nice
|
Merging and deploying to dev first for all services |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cargo-shear(the only one working fine with workspaces)django_compatintegration test into thecapture-servertest suite instead of keeping this dep. Mocking the timesource is the biggest blocker herehttpto 1.1 for hook, to keep in sync with upgraded requestLeft out
governorfor now, will tackle laterTesting
/i/v0/e, liveness, readiness and metric endpoints OK