Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

common: refactor health into its own lib crate #23

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Apr 24, 2024

As more services will be added to the repo, we should have a story around code sharing. This PR uses the health module as a proposition for that code sharing topology. Let's:

  • manage a set of small crates instead of one big common crate: should help avoid side-effects and keep compilation parallelism higher
  • keep the crates un-versioned and un-published for now, imported with a path reference
  • keep the crate names short and simple, but I'm open to adding a ph- prefix all internal crate names to easily differentiate them

I also sorted the Cargo.toml files while I was shuffling stuff around. Overall, this should be a no-op PR.

@xvello xvello requested a review from a team April 24, 2024 12:22
Copy link
Contributor

@tomasfarias tomasfarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

I don't think we need the ph prefix for now, as all crates would be under common/, but maybe if in the future we end up pulling an external crate with a name conflict.

@xvello xvello merged commit 0d48419 into main Apr 24, 2024
4 checks passed
@xvello xvello deleted the xvello/common-health branch April 24, 2024 15:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants