chore: improve linting #26

xvello · 2024-04-24T14:43:52Z

Setup linting config for the whole workspace
- Enable several rustc lints that seem to make sense for us, happy to iterate on it
- Clippy config is still TODO: happy to get suggestion if you have a list of additional lints to enable
Add cargo-shear to the CI to detect unused dependencies: the rustc unused_crate_dependencies lint has false-positives in workspaces.
Merge clippy & format CI jobs into a single linting job (still faster than tests)

xvello requested a review from a team April 24, 2024 14:44

xvello force-pushed the xvello/clippy branch from 984f737 to d24e3da Compare April 24, 2024 14:45

bretthoerner approved these changes Apr 24, 2024

View reviewed changes

xvello force-pushed the xvello/clippy branch from 1c118d4 to e23f2a0 Compare April 24, 2024 15:19

Base automatically changed from xvello/common-health to main April 24, 2024 15:30

xvello added 5 commits April 24, 2024 17:31

add workspace-level linting config

b003af5

enable more rustc lints

a04fcba

add cargo shear to CI

5205a12

run CI on stacked PRs too

d76ed2b

fix

c3226f5

xvello force-pushed the xvello/clippy branch from e23f2a0 to c3226f5 Compare April 24, 2024 15:31

xvello merged commit 60debad into main Apr 24, 2024
4 checks passed

xvello deleted the xvello/clippy branch April 24, 2024 15:39

Provide feedback