Skip to content
This repository has been archived by the owner on Jun 21, 2024. It is now read-only.

Actions docker build: change build-args to a newline delimited string #9

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Actions docker build: change build-args to a newline delimited string #9

merged 1 commit into from
Feb 7, 2024

Conversation

bretthoerner
Copy link
Collaborator

@bretthoerner bretthoerner commented Feb 7, 2024 •
edited
Loading

We're close. 😓 Auth is now working, but build-args is apparently a newline delimited string (Depot is the same): https://github.com/docker/build-push-action#inputs

I merged capture (which only had RUST_BACKTRACE) and rusty-hooks (which requires a BIN) incorrectly here.

@bretthoerner bretthoerner requested a review from a team February 7, 2024 15:38
xvello
xvello approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@xvello xvello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@bretthoerner bretthoerner enabled auto-merge (squash) February 7, 2024 15:41
@bretthoerner bretthoerner merged commit a42a056 into main Feb 7, 2024
4 checks passed
@bretthoerner bretthoerner deleted the brett/build-args branch February 7, 2024 15:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xvello xvello xvello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bretthoerner @xvello