fixes

PostHog · Dec 4, 2024 · 05b4b35 · 05b4b35
1 parent 4969b1a
commit 05b4b35
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 36 deletions.
diff --git a/lib/src/posthog_widget_widget.dart b/lib/src/posthog_widget_widget.dart
@@ -1,11 +1,8 @@
 import 'dart:async';
-import 'dart:ui' as ui;
 
-import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:posthog_flutter/posthog_flutter.dart';
 import 'package:posthog_flutter/src/replay/mask/posthog_mask_controller.dart';
-import 'package:posthog_flutter/src/replay/vendor/equality.dart';
 import 'package:posthog_flutter/src/util/logging.dart';
 
 import 'replay/change_detector.dart';
@@ -27,7 +24,6 @@ class PostHogWidgetState extends State<PostHogWidget> {
   NativeCommunicator? _nativeCommunicator;
 
   Timer? _debounceTimer;
-  Uint8List? _lastSnapshot;
   Duration _debounceDuration = const Duration(milliseconds: 1000);
 
   @override
@@ -77,33 +73,7 @@ class PostHogWidgetState extends State<PostHogWidget> {
           screen: Posthog().currentScreen);
     }
 
-    // using png because its compressed, the native SDKs will decompress it
-    // and transform to jpeg if needed (soon webp)
-    // https://github.com/brendan-duncan/image does not have webp encoding
-    final ByteData? byteData =
-        await imageInfo.image.toByteData(format: ui.ImageByteFormat.png);
-    if (byteData == null) {
-      printIfDebug('Error: Failed to convert image to byte data.');
-      imageInfo.image.dispose();
-      return;
-    }
-
-    Uint8List pngBytes = byteData.buffer.asUint8List();
-    imageInfo.image.dispose();
-
-    if (pngBytes.isEmpty) {
-      printIfDebug('Error: Failed to convert image byte data to Uint8List.');
-      return;
-    }
-
-    if (const PHListEquality().equals(pngBytes, _lastSnapshot)) {
-      printIfDebug('Error: Snapshot is the same as the last one.');
-      return;
-    }
-
-    _lastSnapshot = pngBytes;
-
-    await _nativeCommunicator?.sendFullSnapshot(pngBytes,
+    await _nativeCommunicator?.sendFullSnapshot(imageInfo.imageBytes,
         id: imageInfo.id, x: imageInfo.x, y: imageInfo.y);
   }
 
@@ -127,7 +97,6 @@ class PostHogWidgetState extends State<PostHogWidget> {
     _changeDetector = null;
     _screenshotCapturer = null;
     _nativeCommunicator = null;
-    _lastSnapshot = null;
 
     super.dispose();
   }

diff --git a/lib/src/replay/screenshot/screenshot_capturer.dart b/lib/src/replay/screenshot/screenshot_capturer.dart
@@ -1,9 +1,11 @@
 import 'dart:math';
+import 'dart:typed_data';
 import 'dart:ui' as ui;
 import 'package:flutter/rendering.dart';
 import 'package:posthog_flutter/posthog_flutter.dart';
 import 'package:posthog_flutter/src/replay/mask/image_mask_painter.dart';
 import 'package:posthog_flutter/src/replay/mask/posthog_mask_controller.dart';
+import 'package:posthog_flutter/src/replay/vendor/equality.dart';
 import 'package:posthog_flutter/src/util/logging.dart';
 
 class ImageInfo {
@@ -14,13 +16,15 @@ class ImageInfo {
   final int width;
   final int height;
   final bool shouldSendMetaEvent;
+  Uint8List imageBytes;
 
   ImageInfo(this.image, this.id, this.x, this.y, this.width, this.height,
-      this.shouldSendMetaEvent);
+      this.shouldSendMetaEvent, this.imageBytes);
 }
 
 class ViewTreeSnapshotStatus {
   bool sentMetaEvent = false;
+  Uint8List? imageBytes;
   ViewTreeSnapshotStatus(this.sentMetaEvent);
 }
 
@@ -48,8 +52,8 @@ class ScreenshotCapturer {
       ViewTreeSnapshotStatus statusView) {
     if (shouldSendMetaEvent) {
       statusView.sentMetaEvent = true;
-      _views[renderObject] = statusView;
     }
+    _views[renderObject] = statusView;
   }
 
   Future<ImageInfo?> captureScreenshot() async {
@@ -83,6 +87,32 @@ class ScreenshotCapturer {
 
       final replayConfig = _config.sessionReplayConfig;
 
+      // using png because its compressed, the native SDKs will decompress it
+      // and transform to jpeg if needed (soon webp)
+      // https://github.com/brendan-duncan/image does not have webp encoding
+      final ByteData? byteData =
+          await image.toByteData(format: ui.ImageByteFormat.png);
+      if (byteData == null) {
+        printIfDebug('Error: Failed to convert image to byte data.');
+        image.dispose();
+        return null;
+      }
+
+      Uint8List pngBytes = byteData.buffer.asUint8List();
+      image.dispose();
+
+      if (pngBytes.isEmpty) {
+        printIfDebug('Error: Failed to convert image byte data to Uint8List.');
+        return null;
+      }
+
+      if (const PHListEquality().equals(pngBytes, statusView.imageBytes)) {
+        printIfDebug('Snapshot is the same as the last one.');
+        return null;
+      }
+
+      statusView.imageBytes = pngBytes;
+
       if (replayConfig.maskAllTexts || replayConfig.maskAllImages) {
         final screenElementsRects =
             await PostHogMaskController.instance.getCurrentScreenRects();
@@ -97,7 +127,8 @@ class ScreenshotCapturer {
               globalPosition.dy.toInt(),
               srcWidth.toInt(),
               srcHeight.toInt(),
-              shouldSendMetaEvent);
+              shouldSendMetaEvent,
+              pngBytes);
           _updateStatusView(shouldSendMetaEvent, renderObject, statusView);
           return imageInfo;
         }
@@ -110,7 +141,8 @@ class ScreenshotCapturer {
           globalPosition.dy.toInt(),
           srcWidth.toInt(),
           srcHeight.toInt(),
-          shouldSendMetaEvent);
+          shouldSendMetaEvent,
+          pngBytes);
       _updateStatusView(shouldSendMetaEvent, renderObject, statusView);
       return imageInfo;
     } catch (e) {