Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve error logging when capturing snapshots #146

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

marandaneto
Copy link
Member

💡 Motivation and Context

Closes #145

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@@ -74,7 +74,6 @@ class PostHogWidgetState extends State<PostHogWidget> {

final imageInfo = await _screenshotCapturer?.captureScreenshot();
if (imageInfo == null) {
printIfDebug('Error: Failed to capture screenshot.');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

captureScreenshot will log if anything is errored already

@marandaneto marandaneto requested a review from a team January 8, 2025 09:14
@marandaneto marandaneto marked this pull request as ready for review January 8, 2025 09:14
Copy link

@ioannisj ioannisj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@marandaneto marandaneto merged commit 4fa34da into main Jan 8, 2025
3 checks passed
@marandaneto marandaneto deleted the fix/image-logging branch January 8, 2025 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loop "Error: Failed to capture screenshot" when focus a TextFormField
2 participants