fix: do not start recording buffer without id

[pauldambra]

Things used to start undefined, and they do so much less now

As an effect of that, we start session recording with an absent session and window id

This makes a persistent buffer hard to make since we have no reproducible key

We always have a session manager when we start now, so we can always start with an id

This is mostly tricky in tests, because we have a mock rrweb and then fake around the behavior of snapshots on initialisation

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
posthog-js	✅ Ready (Inspect)	Visit Preview	Jun 1, 2024 4:51pm

[github-actions]

Size Change: +273 B (+0.03%)

Total Size: 973 kB

Filename	Size	Change
dist/array.full.js	234 kB	+69 B (+0.03%)
dist/array.js	131 kB	+68 B (+0.05%)
dist/es.js	131 kB	+68 B (+0.05%)
dist/module.js	131 kB	+68 B (+0.05%)

ℹ️ View Unchanged

Filename	Size
dist/exception-autocapture.js	12.2 kB
dist/recorder-v2.js	109 kB
dist/recorder.js	109 kB
dist/surveys-module-previews.js	57.8 kB
dist/surveys.js	59.5 kB

_{compressed-size-action}

[daibhin]

One thing I noticed in the rrweb spec recently is the concept of checkouts: https://github.com/rrweb-io/rrweb/blob/d7cf8dd07547f6fb22ef82e341a88357c4053bd3/guide.md#checkout

Haven't looked into it fully but it seems like they have methods for capturing the last X events or taking a full snapshot every X ms. Just thought I'd flag it in case we're rebuilding things for the buffer that already exist:

• They suggest checkoutEveryNth is good for capturing events before an error occurred
• Maybe checkoutEveryNms could replace some of our custom timer logic

[pauldambra]

yeah, i tried the checkout every X once and it conflicts with a lot of our custom checkout (or vice versa our custom tracking conflicts with it)

might be worth an attempt to strip this back and save on bundle if nothing else 🤔

[pauldambra]

see

• fix: checkout every X minutes #860
• fix: full snapshot every 10 minutes #847