-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vite + remix app to playground to demo ES Module bug #1293
Conversation
@matt-hernandez is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
amazing, thank you for spending time on this! 💖 |
sorry @matt-hernandez we had a replay incident this week that has absorbed a lot of my time... all sorted now |
@pauldambra I know the feeling too well 😆 |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Still watching this |
Any update on this or quick workaround? This is preventing me from deploying feature flag functionality in our deployed app due to the same issue noted above -
As noted in the original comment, feature flags are working just fine locally with |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Still watching this |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Still watching this |
hey @matt-hernandez i've been unexpectedly out of the office for three weeks so my to-do list is a little unhealthy right now 🙈 haven't forgotten about this though i don't know if @robbie-c has time to look at this before i do but i'll tag him in case i can nerd snipe him |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
We’ve seen a workaround for this that doesn’t seem unreasonable. I need to implement it to verify it on my end |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
Going to try the workaround today. If it works, I'll add it to this PR |
@pauldambra I pushed up a workaround as the latest commit to this PR. I’ll try to give it a good test soon |
@pauldambra I've set up a basic posthog event. If you make a I think this is a valid workaround. We managed to integrate this into our codebase and we're receiving our regular PostHog events without fail. |
Hey @matt-hernandez 🙏 Could you explain it like I'm five? Or at least like I'm someone unfamilar with vite :) |
@pauldambra If you navigate to #908, there are two solutions posted by there by @ekojsalim and @zwhitchcox. Importing from |
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Changes
This PR adds a Remix + Vite project to the app to demonstrate issue #908 . In order to reproduce that issue, you have to do
npm run build
and thennpm start
. This runs the app as if it's in a production environment. The app will crash and produce this output:This bug is not reproducible when running
npm run dev
, which is the strangest behavior. It happens when running the app after build and during e2e tests that involve running a built version of the app in Playwright....
Checklist