feat: Use NavigatorUAData and navigator.webdriver to improve bot detection #1359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.18 kB (+0.1%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
robbie-c
force-pushed
the
feat/detect-headless-browsers
branch
from
ca1dab7
to
8cb7d1e
Compare
pauldambra
approved these changes
Aug 20, 2024
| /// <reference types="cypress" /> | ||
| import { start } from '../support/setup' | ||
|
|
||
| describe('User Agent Blocking', () => { |
Comment on lines
+2036
to
+2038
| if (navigator) { | ||
| return isLikelyBot(navigator, this.config.custom_blocked_useragents) | ||
| } else { |
There was a problem hiding this comment.
the only thing that gives me pause - and i've helpfully not thought about this at all - is the change from userAgent being required to navigator being required.
my assumption is this is ok because if we're in an environment with no navigator then we also have no userAgent...
There was a problem hiding this comment.
Yeah - I can see why there would be situations where people might want to pass a userAgent, but we currently get the userAgent by doing navigator.userAgent so any environment without a navigator won't have a userAgent, so this is no change.
Phanatic
pushed a commit
that referenced
this pull request
Aug 20, 2024
…ction (#1359) * Use NavigatorUAData and navigator.webdriver to improve bot detection * Use real values of brands from headless and regular chrome in tests * Reduce bundle size slightly * Remove global * Fix test setup * Opt out of bot filtering in cypress * Make _is_likely_bot an instance function on posthog, use it in cypress tests * Fix cypress imports * Code golf * More code golf * Fix testcafe tests * Treat cypress as a bot * Fix cypress chaining logic
3 tasks
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We weren't detecting some headless browsers in our bot detection, so I've added headless chrome to the list of blocked UAs. See this zendesk ticket https://posthoghelp.zendesk.com/agent/tickets/16802
We weren't using the
navigator.webdriverfield, so I've added that to the check as well.I've also added some support for NavigatorUAData, so that we detect headless chrome where the --useragent argument is changed to something else
Checklist