Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move chrome tests off of browserstack, add firefox #1369

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

robbie-c
Copy link
Contributor

@robbie-c robbie-c commented Aug 19, 2024

Changes

We can run chrome on the actions runner without needing to use browserstack. This means that we only use 2 of our 5 browserstack concurrent tests per PR rather than 3, which lets us have 2 PRs running tests in parallel.

I also added headless firefox because why not.

Checklist

  • Tests for new code (see advice on the tests we use)
  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 19, 2024 5:09pm

Copy link

github-actions bot commented Aug 19, 2024

Size Change: 0 B

Total Size: 1.17 MB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 333 kB
dist/array.js 154 kB
dist/exception-autocapture.js 10.4 kB
dist/main.js 155 kB
dist/module.js 154 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

@robbie-c robbie-c changed the title chore: Move chrome tests off of browserstack chore: Move chrome tests off of browserstack, add firefox Aug 20, 2024
@robbie-c robbie-c marked this pull request as ready for review August 20, 2024 10:52
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦾 love it

(can make the firefox job required after this too?)

@robbie-c robbie-c merged commit 57c3b46 into main Aug 20, 2024
19 checks passed
@robbie-c robbie-c deleted the chore/move-chrome-off-browserstack branch August 20, 2024 14:05
@robbie-c
Copy link
Contributor Author

I don't have powers to do that but if you do then please go ahead :)

@pauldambra
Copy link
Member

ugh, i don't any more :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants