fix: capture a $pageview event on opting in #1372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: +1.06 kB (+0.09%) Total Size: 1.17 MB
ℹ️ View Unchanged
|
…-pageview-on-opt-in
benjackwhite
requested changes
Aug 27, 2024
src/posthog-core.ts
Outdated
Comment on lines
1988
to
1991
| if (this.config.capture_pageview && !this._initialPageviewCaptured && document) { | ||
| this._initialPageviewCaptured = true | ||
| this.capture('$pageview', { title: document.title }, { send_instantly: true }) | ||
| } |
There was a problem hiding this comment.
Could we move this block into a private method like captureInitialPageview instead. that way it isn't likely to get forgotten about later in one place or the other
There was a problem hiding this comment.
Thanks @benjackwhite! I added a private method.
benjackwhite
approved these changes
Aug 28, 2024
|
Approved - dont forget to bump the label |
This was referenced Sep 24, 2024
This was referenced Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The initial
$pageviewis not captured when customers use the opt in/out flow. It creates a discrepancy in event count like this one. The PR changes the behavior to capture the initial$pageviewevent after a user opts in if the event hasn't yet been sent.Before
After
Checklist