Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event listeners should obey start and stop #1379

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Aug 22, 2024

fixes: #1378

instead of registering these event listeners in the constructor we should register when starting and unregister them when stopping

tested by running locally and validating that i still see browser hidden events

Copy link

vercel bot commented Aug 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Aug 26, 2024 1:50pm

@pauldambra pauldambra requested a review from a team August 22, 2024 10:53
@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Aug 22, 2024
Copy link

github-actions bot commented Aug 22, 2024

Size Change: +1.74 kB (+0.15%)

Total Size: 1.17 MB

Filename Size Change
dist/array.full.js 334 kB +440 B (+0.13%)
dist/array.js 155 kB +432 B (+0.28%)
dist/main.js 156 kB +432 B (+0.28%)
dist/module.js 155 kB +432 B (+0.28%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 10.4 kB
dist/recorder-v2.js 110 kB
dist/recorder.js 110 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.26 kB
dist/web-vitals.js 5.79 kB

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Session Recording warnings when disable_session_recording = true
3 participants