feat: web vitals 3000 fallback #1404
Conversation
|
@brunomguimaraes is attempting to deploy a commit to the PostHog Team on Vercel. A member of the Team first needs to authorize it. |
| @@ -200,7 +200,10 @@ export class WebVitalsAutocapture { | |||
| if (!isUndefined(posthogExtensions)) { | |||
| ;({ onLCP, onCLS, onFCP, onINP } = posthogExtensions.postHogWebVitalsCallbacks) | |||
| } | |||
|
|
|||
| else if (assignableWindow.postHogWebVitalsCallbacks) { | |||
There was a problem hiding this comment.
hey @brunomguimaraes this shouldn't be necessary, what's the problem this solves?
There was a problem hiding this comment.
Ugh, dang... It's because we load the latest web vitals extension into older clients. What a pain 😭
AFK right now will look at this properly when back
There was a problem hiding this comment.
Exactly @pauldambra !
I've probably should've explain that better on the PR
There was a problem hiding this comment.
:)
I should have caught it... have opened #1407 to try and work towards making this all safer
|
hey @brunomguimaraes this wouldn't fix the issue for old clients since they wouldn't have this new code i've opened #1406 instead, thanks for flagging this though |
#1401