Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build when publishing #1430

Merged
merged 2 commits into from
Sep 23, 2024
Merged

chore: build when publishing #1430

merged 2 commits into from
Sep 23, 2024

Conversation

pauldambra
Copy link
Member

We run tests when publishing that assume the lib was built...

So this should fix it

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Sep 23, 2024 2:19pm

Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better would be to swap the order in the prePublish command of the package json tbh

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Sep 23, 2024
Copy link

github-actions bot commented Sep 23, 2024

Size Change: 0 B

Total Size: 2.79 MB

ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 191 kB
dist/array.full.js 350 kB
dist/array.full.no-external.js 349 kB
dist/array.js 165 kB
dist/array.no-external.js 164 kB
dist/exception-autocapture.js 10.5 kB
dist/external-scripts-loader.js 2.35 kB
dist/main.js 165 kB
dist/module.full.js 349 kB
dist/module.full.no-external.js 348 kB
dist/module.js 165 kB
dist/module.no-external.js 164 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@pauldambra pauldambra merged commit 44e820b into main Sep 23, 2024
16 checks passed
@pauldambra pauldambra deleted the chore/build-when-publishing branch September 23, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants