Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove posthog error capture from replay #1454

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Oct 7, 2024

We shouldn't be capturing auto posthog errors unless the integration is on... will remove this from replay for now

Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 7, 2024 0:49am

@pauldambra pauldambra added the bump patch Bump patch version when this PR gets merged label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Size Change: -504 B (-0.02%)

Total Size: 2.8 MB

Filename Size Change
dist/array.full.js 351 kB -56 B (-0.02%)
dist/array.full.no-external.js 350 kB -56 B (-0.02%)
dist/array.js 167 kB -56 B (-0.03%)
dist/array.no-external.js 165 kB -56 B (-0.03%)
dist/main.js 167 kB -56 B (-0.03%)
dist/module.full.js 351 kB -56 B (-0.02%)
dist/module.full.no-external.js 350 kB -56 B (-0.02%)
dist/module.js 167 kB -56 B (-0.03%)
dist/module.no-external.js 166 kB -56 B (-0.03%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 191 kB
dist/exception-autocapture.js 10.5 kB
dist/external-scripts-loader.js 2.35 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@JakeRuth
Copy link

JakeRuth commented Oct 7, 2024

thanks for this and building in public! Excited to get this change in a new version of the psothogjs lib, it will really reduce spam in our live metrics

@pauldambra pauldambra merged commit c78552d into main Oct 7, 2024
18 checks passed
@pauldambra pauldambra deleted the fix/remove-posthog-error-capture-from-replay branch October 7, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants