Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(surveys): Make entire cancel button area clickable #1473

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Phanatic
Copy link
Contributor

Changes

Resolves PostHog/posthog#25594
The Cancel button on a survey right now attaches the click handler to the tiny X in the close button.
This PR makes the entire Circle and the X inside it clickable.

image

Checklist

  • Accounted for the impact of any changes across different browsers
  • Accounted for backwards compatibility of any changes (no breaking changes in posthog-js!)

Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 15, 2024 6:13pm

Copy link

Size Change: +231 B (+0.01%)

Total Size: 2.83 MB

Filename Size Change
dist/all-external-dependencies.js 192 kB +33 B (+0.02%)
dist/array.full.js 355 kB +33 B (+0.01%)
dist/array.full.no-external.js 353 kB +33 B (+0.01%)
dist/module.full.js 354 kB +33 B (+0.01%)
dist/module.full.no-external.js 353 kB +33 B (+0.01%)
dist/surveys-preview.js 59.9 kB +33 B (+0.06%)
dist/surveys.js 66 kB +33 B (+0.05%)
ℹ️ View Unchanged
Filename Size
dist/array.js 169 kB
dist/array.no-external.js 168 kB
dist/exception-autocapture.js 11.1 kB
dist/external-scripts-loader.js 2.35 kB
dist/main.js 170 kB
dist/module.js 169 kB
dist/module.no-external.js 168 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@Phanatic Phanatic added the bump minor Bump minor version when this PR gets merged label Oct 17, 2024
@Phanatic Phanatic merged commit ba9179c into main Oct 17, 2024
17 checks passed
@Phanatic Phanatic deleted the make-close-easier branch October 17, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey close button not fully responsive on mobile
3 participants