Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip if Array.from is missing #1475

Merged
merged 2 commits into from
Oct 16, 2024
Merged

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Oct 16, 2024

Changes

When upgrading rrweb in #1276 we had some failing tests on IE11:

TypeError: Object doesn't support property or method 'from'

This is because the Array.from method is not supported on IE11 and it seems like rrweb internals have changed such that it is now called as part of our tests when upgrading.

Proposal is to remove it in this PR and then upgrade rrweb in the separate PR linked

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog-js ✅ Ready (Inspect) Visit Preview Oct 16, 2024 9:15am

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

Copy link

Size Change: +148 B (+0.01%)

Total Size: 2.83 MB

Filename Size Change
dist/array.full.js 355 kB +17 B (0%)
dist/array.full.no-external.js 353 kB +17 B (0%)
dist/array.js 169 kB +16 B (+0.01%)
dist/array.no-external.js 168 kB +16 B (+0.01%)
dist/main.js 170 kB +16 B (+0.01%)
dist/module.full.js 354 kB +17 B (0%)
dist/module.full.no-external.js 353 kB +17 B (0%)
dist/module.js 169 kB +16 B (+0.01%)
dist/module.no-external.js 168 kB +16 B (+0.01%)
ℹ️ View Unchanged
Filename Size
dist/all-external-dependencies.js 192 kB
dist/exception-autocapture.js 11.1 kB
dist/external-scripts-loader.js 2.35 kB
dist/recorder-v2.js 111 kB
dist/recorder.js 111 kB
dist/surveys-preview.js 59.8 kB
dist/surveys.js 66 kB
dist/tracing-headers.js 8.36 kB
dist/web-vitals.js 10.3 kB

compressed-size-action

@daibhin daibhin added bump minor Bump minor version when this PR gets merged bump patch Bump patch version when this PR gets merged and removed bump minor Bump minor version when this PR gets merged labels Oct 16, 2024
@daibhin daibhin merged commit bd173b2 into main Oct 16, 2024
19 checks passed
@daibhin daibhin deleted the dn-chore/skip-array-from-missing branch October 16, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants