feat: callback when session id changes #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +2.14 kB (0%) Total Size: 664 kB
ℹ️ View Unchanged
|
neilkakkar
approved these changes
Jul 7, 2023
src/sessionid.ts
Outdated
| @@ -26,6 +28,10 @@ export class SessionIdManager { | |||
| this._sessionStartTimestamp = null | |||
| this._sessionActivityTimestamp = null | |||
|
|
|||
| if (this.config.on_session_id_changed_fn) { | |||
There was a problem hiding this comment.
Optional API design idea:
This seems a bit awkward to use to me, since I have to copy all my business logic to posthog at initialisation time, when it might not exist (say, I need to load user data so I can feed these new sessionID values to the backend, bla bla). I also can't change this during the session posthog is initialised.
Another option here is to expose the callback function instead: Whenever the sessionID changes, we call the onSessionIdChanged with whatever has happened. You can remove your callback fns, add new ones, attach in the middle when you're ready to handle, etc. etc.
See onFeatureFlags() callback for an example of this.
pauldambra
commented
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
See zendesk ticket https://posthoghelp.zendesk.com/agent/tickets/4038
If someone wants to filter for session recordings using backend events. They can't, because we can only filter for events that have a $session_id property.
We don't care how the event got that property.
Adds an optional callback to config that is called with session id and window id whenever either changes. Some can use this to synchronise the session id to their backend and allow it to enrich events with the session id
Checklist