Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unused capture metrics #766

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

pauldambra
Copy link
Member

@pauldambra pauldambra commented Aug 1, 2023

We don't use this... let's see what impact removing it has on bundle size

Only 1% but 1% is 1%

@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Size Change: -7.52 kB (-1%)

Total Size: 668 kB

Filename Size Change
dist/array.full.js 173 kB -1.88 kB (-1%)
dist/array.js 115 kB -1.88 kB (-2%)
dist/es.js 114 kB -1.88 kB (-2%)
dist/module.js 115 kB -1.88 kB (-2%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 93.6 kB
dist/recorder.js 58.3 kB

compressed-size-action

@benjackwhite benjackwhite added bump minor Bump minor version when this PR gets merged bump patch Bump patch version when this PR gets merged and removed bump minor Bump minor version when this PR gets merged labels Aug 2, 2023
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. It always confused me so happy to be getting rid of it

@pauldambra pauldambra merged commit e18a861 into master Aug 2, 2023
13 checks passed
@pauldambra pauldambra deleted the chore/remove-unused-capture-metrics branch August 2, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants