Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mitigate testcafe flakiness #779

Merged
merged 7 commits into from
Aug 22, 2023
Merged

fix: Mitigate testcafe flakiness #779

merged 7 commits into from
Aug 22, 2023

Conversation

robbie-c
Copy link
Contributor

@robbie-c robbie-c commented Aug 21, 2023 •
edited
Loading

Changes

Attempting to fix #778

  • Add BROWSERSTACK_FORCE_PROXY and BROWSERSTACK_USE_AUTOMATE which fixed the specific problem around the cloud safari connecting to the test page
  • Use a cache to speed up yarn install
  • Add a script which will rerun testcafe tests up to 3 times

Checklist

@posthog-bot
Copy link
Collaborator

Hey @robbie-c! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

@robbie-c robbie-c changed the title Pin the testcafe version fix: Pin the testcafe version Aug 21, 2023
@github-actions
Copy link

github-actions bot commented Aug 21, 2023 •
edited
Loading

Size Change: 0 B

Total Size: 675 kB

ℹ️ View Unchanged
Filename Size
dist/array.full.js 175 kB
dist/array.js 116 kB
dist/es.js 116 kB
dist/module.js 116 kB
dist/recorder-v2.js 93.6 kB
dist/recorder.js 58.3 kB

compressed-size-action

@robbie-c robbie-c force-pushed the fix-testcafe-tests branch 2 times, most recently from 1d2cc56 to 27edaa3 Compare August 21, 2023 09:27
@robbie-c robbie-c marked this pull request as ready for review August 21, 2023 09:27
@robbie-c robbie-c changed the title fix: Pin the testcafe version fix: Mitigate testcafe flakiness Aug 21, 2023
@robbie-c robbie-c force-pushed the fix-testcafe-tests branch 2 times, most recently from 8470d4b to 11545da Compare August 21, 2023 09:57
@robbie-c robbie-c requested a review from Twixes August 21, 2023 10:34
@robbie-c robbie-c mentioned this pull request Aug 21, 2023
Closed
2 tasks
Twixes
Twixes approved these changes Aug 21, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
benjackwhite
benjackwhite approved these changes Aug 21, 2023
View reviewed changes
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@robbie-c robbie-c merged commit 65171a4 into master Aug 22, 2023
11 checks passed
@robbie-c robbie-c deleted the fix-testcafe-tests branch August 22, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjackwhite benjackwhite benjackwhite approved these changes

@Twixes Twixes Twixes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Testcafe.yml tests are flaky
4 participants
@robbie-c @posthog-bot @benjackwhite @Twixes