Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove complex get_config #812

Merged
merged 8 commits into from
Sep 28, 2023
Merged

Conversation

benjackwhite
Copy link
Collaborator

@benjackwhite benjackwhite commented Sep 27, 2023

Changes

Removes a legacy param asked about here

We have a special accessor for the config that doesn't actually do anything whilst also making it really hard to infer types.
This PR gets rid of it and simply accesses the config object.

The "given" concept in tests is a real headache we should move away from... Tried to fix tests without getting too lost in refactoring for now

Checklist

@github-actions
Copy link

github-actions bot commented Sep 27, 2023

Size Change: -3.11 kB (0%)

Total Size: 706 kB

Filename Size Change
dist/array.full.js 176 kB -778 B (0%)
dist/array.js 118 kB -778 B (-1%)
dist/es.js 118 kB -778 B (-1%)
dist/module.js 118 kB -778 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB
dist/surveys.js 23.6 kB

compressed-size-action

@benjackwhite benjackwhite marked this pull request as ready for review September 27, 2023 07:56
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Sep 28, 2023
@benjackwhite benjackwhite merged commit 4b08aff into master Sep 28, 2023
12 checks passed
@benjackwhite benjackwhite deleted the fix/remove-legacy-params branch September 28, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants