Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): open text value bug #825

Merged
merged 1 commit into from
Oct 5, 2023
Merged

fix(surveys): open text value bug #825

merged 1 commit into from
Oct 5, 2023

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 5, 2023

Changes

Open text input value was using the on change value instead of the full textbox value, which meant when you typed and then went backspace, it would disable the submit button.

Checklist

@liyiy liyiy added the bump patch Bump patch version when this PR gets merged label Oct 5, 2023
@liyiy liyiy requested a review from neilkakkar October 5, 2023 19:58
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Size Change: +8 B (0%)

Total Size: 726 kB

Filename Size Change
dist/surveys.js 38.7 kB +8 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 119 kB
dist/es.js 119 kB
dist/module.js 119 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

@liyiy liyiy merged commit 44cf350 into master Oct 5, 2023
12 checks passed
@liyiy liyiy deleted the fix-surveys-open-input branch October 5, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant