Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow backend to specify a custom analytics endpoint #831

Merged
merged 8 commits into from
Oct 26, 2023

Conversation

xvello
Copy link
Contributor

@xvello xvello commented Oct 12, 2023

Changes

  • Handle a new analytics.endpoint field in the decide response to allow us to slowly move posthog-js traffic to the new intake endpoint
  • Move the compression configuration code to posthog-core.ts too for separation of concerns

Checklist

@github-actions
Copy link

github-actions bot commented Oct 12, 2023

Size Change: +904 B (0%)

Total Size: 710 kB

Filename Size Change
dist/array.full.js 170 kB +226 B (0%)
dist/array.js 112 kB +226 B (0%)
dist/es.js 111 kB +226 B (0%)
dist/module.js 112 kB +226 B (0%)
ℹ️ View Unchanged
Filename Size
dist/exception-autocapture.js 12 kB
dist/recorder-v2.js 95.1 kB
dist/recorder.js 58.4 kB
dist/surveys.js 39.7 kB

compressed-size-action

@xvello xvello force-pushed the xvello/analyticsendpoint branch 2 times, most recently from f9a474a to e5ab7f9 Compare October 12, 2023 09:57
@neilkakkar neilkakkar added the bump minor Bump minor version when this PR gets merged label Oct 23, 2023
@@ -46,68 +42,3 @@ describe('compressData()', () => {
expect(given.subject).toMatchSnapshot()
})
})

describe('Payload Compression', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing as it's already covered by the tests in decide.js + posthog-core.js

@xvello xvello marked this pull request as ready for review October 23, 2023 13:48
Copy link
Collaborator

@neilkakkar neilkakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense! 🚀

Copy link

@ellie ellie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@xvello xvello merged commit 716dd2a into master Oct 26, 2023
11 checks passed
@xvello xvello deleted the xvello/analyticsendpoint branch October 26, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor Bump minor version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants