chore: refactor session tests #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Oct 13, 2023
| @@ -52,7 +52,10 @@ module.exports = { | |||
| // but excluding the 'plugin:compat/recommended' rule | |||
| // we don't mind using the latest features in our tests | |||
| extends: extend.filter((s) => s !== 'plugin:compat/recommended'), | |||
| rules: rules.filter((s) => s !== 'no-console'), | |||
| rules: { | |||
There was a problem hiding this comment.
I couldn't run eslint until changing this
pauldambra
commented
Oct 13, 2023
| given.sessionRecording._onScriptLoaded() | ||
| console_log_enabled_server_side = false | ||
| // access private method 🤯 | ||
| sessionRecording['_onScriptLoaded']() |
There was a problem hiding this comment.
we interact with private methods quite a lot
- it's super easy to have TS ignore that the thing is private 🤣
- it didn't seem right to declare them as public or protected only to access them from tests, so this index lookup mechanism instead
|
Size Change: +439 B (0%) Total Size: 725 kB
ℹ️ View Unchanged
|
benjackwhite
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move session recording tests off of given and into typescript