Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(surveys): add listener to 0th element #837

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix(surveys): add listener to 0th element #837

merged 1 commit into from
Oct 17, 2023

Conversation

neilkakkar
Copy link
Collaborator

Changes

Missed the event listener for the 0th element, which means no NPS responses for 0 would come in #featureNotABug

Checklist

@neilkakkar neilkakkar added the bump patch Bump patch version when this PR gets merged label Oct 17, 2023
@neilkakkar neilkakkar marked this pull request as ready for review October 17, 2023 13:56
@github-actions
Copy link

Size Change: -20 B (0%)

Total Size: 725 kB

Filename Size Change
dist/surveys.js 39.4 kB -20 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 118 kB
dist/es.js 118 kB
dist/module.js 118 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

@neilkakkar neilkakkar merged commit b5d3c8b into master Oct 17, 2023
12 checks passed
@neilkakkar neilkakkar deleted the survey-fix branch October 17, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liyiy liyiy liyiy approved these changes

@jurajmajerik jurajmajerik Awaiting requested review from jurajmajerik

Assignees
No one assigned
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neilkakkar @liyiy