Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(surveys): fix multiple choice input unique ID bug #841

Merged
merged 2 commits into from
Oct 19, 2023
Merged

Conversation

liyiy
Copy link
Contributor

@liyiy liyiy commented Oct 19, 2023

Changes

There was a bug in multiple question surveys where if you had 2 or more multiple choice type questions in the mix, you would be unable to select the input properly because the input IDs in the element were exactly the same

This PR adds a questionIndex identifier to the question elements so that it's more unique. It's really only needed for multiple choice type questions but doesn't hurt to have for the others too.

mcq-id-bug.mov

Checklist

@github-actions
Copy link

github-actions bot commented Oct 19, 2023

Size Change: +131 B (0%)

Total Size: 725 kB

Filename Size Change
dist/surveys.js 39.6 kB +131 B (0%)
ℹ️ View Unchanged
Filename Size
dist/array.full.js 177 kB
dist/array.js 118 kB
dist/es.js 118 kB
dist/module.js 118 kB
dist/recorder-v2.js 95 kB
dist/recorder.js 58.3 kB

compressed-size-action

@liyiy liyiy added the bump patch Bump patch version when this PR gets merged label Oct 19, 2023
@liyiy liyiy merged commit a6ed7e9 into master Oct 19, 2023
11 checks passed
@liyiy liyiy deleted the fix-surveys-mcq branch October 19, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants