feat: Toolbar loading from state faster #849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +623 B (0%) Total Size: 723 kB
ℹ️ View Unchanged
|
pauldambra
reviewed
Oct 24, 2023
| import { PostHog } from '../posthog-core' | ||
| import { DecideResponse, ToolbarParams } from '../types' | ||
| import { POSTHOG_MANAGED_HOSTS } from './cloud' | ||
|
|
||
| // TRICKY: Many web frameworks will modify the route on load, potentially before posthog is initialized. | ||
| // To get ahead of this we grab it as soon as the posthog-js is parsed | ||
| const STATE_FROM_WINDOW = window.location |
pauldambra
reviewed
Oct 24, 2023
| @@ -274,6 +274,14 @@ export const _formatDate = function (d: Date): string { | |||
| ) | |||
| } | |||
|
|
|||
| export const _try = function <T>(fn: () => T): T | undefined { | |||
pauldambra
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Definitely worth a try. Or rather this should definitely work...
Ignoring heatmap this is the #1 support load from toolbar so 🏅 for you if this works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Seems like a lot of web frameworks get in the way of us pulling the state from the location hash. Hacky fix for this is to try and get this info the moment the page loads, rather than after the sdk is initialised.
Checklist