Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log browser offline status #850

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

jurajmajerik
Copy link
Contributor

Changes

Add Browser is offline to logs when the browser is offline.
We're seeing frequent "Failed to fetch feature flags" errors with one of our users and want to rule out connection issues as the cause.

Slack thread: https://posthog.slack.com/archives/C0522G09STW/p1698051029628329

Checklist

@jurajmajerik jurajmajerik added the bump patch Bump patch version when this PR gets merged label Oct 24, 2023
@github-actions
Copy link

Size Change: +220 B (0%)

Total Size: 723 kB

Filename Size Change
dist/array.full.js 176 kB +55 B (0%)
dist/array.js 118 kB +55 B (0%)
dist/es.js 118 kB +55 B (0%)
dist/module.js 118 kB +55 B (0%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 95.1 kB
dist/recorder.js 58.4 kB
dist/surveys.js 39.6 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really interested to see how this goes....

would be cool, for example, to stop retrying while offline

@jurajmajerik jurajmajerik merged commit 0448cef into master Oct 24, 2023
14 checks passed
@jurajmajerik jurajmajerik deleted the chore/log-browser-offline branch October 24, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants