Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable the string reduction code until we can battle test it more. #851

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

benjackwhite
Copy link
Collaborator

Changes

Disables the may size checker for now. This should be less of a big deal with our new ingestion pipeline, but more importantly it doesn't at all work as expected. It replaces big data values in some cases but often it actually just modifies a big snapshots, where there happen to be a bunch of data urls.

We should definitely add it back in and figure out how to do this more cleverly but for now lets remove it and watch to see what happens.

Checklist

@benjackwhite benjackwhite added the bump patch Bump patch version when this PR gets merged label Oct 24, 2023
@github-actions
Copy link

github-actions bot commented Oct 24, 2023

Size Change: -2.7 kB (0%)

Total Size: 728 kB

Filename Size Change
dist/array.full.js 178 kB -676 B (0%)
dist/array.js 119 kB -676 B (-1%)
dist/es.js 119 kB -676 B (-1%)
dist/module.js 119 kB -676 B (-1%)
ℹ️ View Unchanged
Filename Size
dist/recorder-v2.js 95.1 kB
dist/recorder.js 58.4 kB
dist/surveys.js 39.7 kB

compressed-size-action

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

could comment on ensureMaxMessageSize to mark it as purposefully unused but 🤷

@benjackwhite benjackwhite merged commit d2f1ad2 into master Oct 24, 2023
13 checks passed
@benjackwhite benjackwhite deleted the fix/util-parsing branch October 24, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch Bump patch version when this PR gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants