feat: lazily load exception autocapture #856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -30.7 kB (-4%) Total Size: 709 kB
ℹ️ View Unchanged
|
benjackwhite
requested changes
Oct 25, 2023
| import { PostHog } from '../../posthog-core' | ||
| import { DecideResponse, Properties } from '../../types' | ||
| import { ErrorEventArgs, ErrorProperties, errorToProperties, unhandledRejectionToProperties } from './error-conversion' | ||
| import { isPrimitive } from './type-checking' | ||
|
|
||
| const EXCEPTION_INGESTION_ENDPOINT = '/e/' | ||
|
|
||
| export const extendPostHog = (instance: PostHog, response: DecideResponse) => { |
There was a problem hiding this comment.
The place I could see this being called, the decide response isn't passed?
benjackwhite
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a while until we're going to be able to work on exception autocapture as events but we ship the code to everyone. No bueno.
Move it to lazy loading so things are there when we're ready to use them. Reduces bundle by c7%
Nit-pickingly this is a breaking change by removing
posthog.captureExceptionbut we don't see any events logged from that in the last 90 days