feat(surveys): Make selector targeting work, add user props #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +17 B (0%) Total Size: 729 kB
ℹ️ View Unchanged
|
jurajmajerik
approved these changes
Oct 26, 2023
liyiy
reviewed
Oct 26, 2023
| @@ -457,6 +460,9 @@ export const addCancelListeners = ( | |||
| $survey_name: surveyEventName, | |||
| $survey_id: surveyId, | |||
| sessionRecordingUrl: posthog.get_session_replay_url?.(), | |||
| $set: { | |||
| [`$survey_dismiss/${surveyId}`]: true, | |||
There was a problem hiding this comment.
I think this was still in draft mode when I looked at it yesterday :( but this is probably better as survey_dismissed
There was a problem hiding this comment.
Like one can probably gather what it's meant to do even with just "survey dismiss" but we do feature_flag_called and it makes a lot more sense than if we did feature_flag_call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
implements option 3 from: PostHog/posthog#17863
and fixes PostHog/posthog#17652
~~Still need to test perf impact of the setInterval 👀 ~~ - processing takes about 2-3ms per run, and minimal CPU resources, so ok to run on a regular interval. I doubled the interval anyway to keep the check at 1/1000th of the cycle (3s cycle, 3ms per run)
Still need to add a few tests here
...
Checklist