fix: logging pointless error when offline #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pauldambra
commented
Oct 30, 2023
Comment on lines
+23
to
+28
| const text = xmlHttpRequest.responseText | ||
| if (!text || !text.length) { | ||
| return | ||
| } | ||
|
|
||
| const response: CaptureResponse = JSON.parse(text) |
There was a problem hiding this comment.
this is the actual fix (ignoring the noise from refactoring logger into its own file to make it easier to mock the smallest area in the test)
|
Size Change: -16 B (0%) Total Size: 712 kB
ℹ️ View Unchanged
|
clarity on impact on bundle size from splitting utils continues to increase |
neilkakkar
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When testing #864 I noticed that the rate limiter can't cope with an empty body which is what you get when the network is offline
Well, not any more!