Fixed react hook ordering

PostHog · Jun 12, 2024 · 567860b · 567860b
1 parent 2e60b33
commit 567860b
Showing 1 changed file with 14 additions and 10 deletions.
diff --git a/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx b/frontend/src/lib/components/DefinitionPopover/DefinitionPopoverContents.tsx
@@ -174,19 +174,23 @@ function DefinitionView({ group }: { group: TaxonomicFilterGroup }): JSX.Element
             </>
         )
     }
-    if (isProperty) {
+
+    const hasSentAsLabel = useMemo(() => {
         const _definition = definition as PropertyDefinition
-        const hasSentAsLabel = useMemo(() => {
-            if (isDataWarehousePersonProperty) {
-                return _definition.id
-            }
 
-            if (_definition.name !== '') {
-                return _definition.name
-            }
+        if (isDataWarehousePersonProperty) {
+            return _definition.id
+        }
 
-            return <i>(empty string)</i>
-        }, [isDataWarehousePersonProperty, _definition])
+        if (_definition.name !== '') {
+            return _definition.name
+        }
+
+        return <i>(empty string)</i>
+    }, [isDataWarehousePersonProperty, definition, isProperty])
+
+    if (isProperty) {
+        const _definition = definition as PropertyDefinition
 
         return (
             <>