fix(surveys): small bug fixes (#17327)

PostHog · Sep 5, 2023 · e576e52 · e576e52
1 parent 7b65dd3
commit e576e52
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/frontend/src/scenes/surveys/SurveyView.tsx b/frontend/src/scenes/surveys/SurveyView.tsx
@@ -68,9 +68,11 @@ export function SurveyView({ id }: { id: string }): JSX.Element {
                                                 </LemonButton>
                                                 <LemonDivider />
                                             </>
-                                            <LemonButton onClick={() => archiveSurvey()} fullWidth>
-                                                Archive
-                                            </LemonButton>
+                                            {survey.end_date && !survey.archived && (
+                                                <LemonButton onClick={() => archiveSurvey()} fullWidth>
+                                                    Archive
+                                                </LemonButton>
+                                            )}
                                             <LemonButton status="danger" fullWidth onClick={() => deleteSurvey(id)}>
                                                 Delete survey
                                             </LemonButton>

diff --git a/frontend/src/scenes/surveys/surveysLogic.tsx b/frontend/src/scenes/surveys/surveysLogic.tsx
@@ -7,6 +7,7 @@ import { urls } from 'scenes/urls'
 import type { surveysLogicType } from './surveysLogicType'
 import { lemonToast } from '@posthog/lemon-ui'
 import { userLogic } from 'scenes/userLogic'
+import { router } from 'kea-router'
 
 export function getSurveyStatus(survey: Survey): ProgressStatus {
     if (!survey.start_date) {
@@ -40,6 +41,7 @@ export const surveysLogic = kea<surveysLogicType>([
     listeners(() => ({
         deleteSurveySuccess: () => {
             lemonToast.success('Survey deleted')
+            router.actions.push(urls.surveys())
         },
         updateSurveySuccess: () => {
             lemonToast.success('Survey updated')

diff --git a/...-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png b/...-snapshots/Navigation-App-Page-With-Side-Bar-Hidden-Mobile-1-chromium-linux.png
diff --git a/...s-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png b/...s-snapshots/Navigation-App-Page-With-Side-Bar-Shown-Mobile-1-chromium-linux.png