fix(surveys): Fix survey prop naming #18225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilkakkar
reviewed
Oct 26, 2023
frontend/src/lib/taxonomy.tsx
Outdated
| @@ -826,6 +826,14 @@ export function getKeyMapping( | |||
| description: `The response value for the ${index}${suffix} question in the survey.`, | |||
| } | |||
| } | |||
| } else if (value.startsWith('$survey_responded/')) { | |||
There was a problem hiding this comment.
this one's already on line 800, just edit that?
There was a problem hiding this comment.
isn't that for the event property survey_response?
There was a problem hiding this comment.
oh no wait it has a slash in it. I assume survey_response_ handles survey_response from the event property?
There was a problem hiding this comment.
Yeah I think I added it a while ago LOL nvm
There was a problem hiding this comment.
There's a separate one in KEY_MAPPINGS for the response. These ones are needed only when it's a programmatic property, i.e some part changes, like the id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
dismiss -> dismissed
PostHog/posthog-js#861
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?