chore(clickhouse): Capture final SQL in Sentry errors #21436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
approved these changes
Apr 9, 2024
|
:O Let's use the new clickhouse-driver integration that we get by upgrading 
|
Twixes
force-pushed
the
capture-full-error-sql
branch
from
e19c0dc
to
ddb241c
Compare
marandaneto
reviewed
Apr 9, 2024
Twixes
force-pushed
the
capture-full-error-sql
branch
2 times, most recently
from
5b7892e
to
8836050
Compare
Twixes
force-pushed
the
capture-full-error-sql
branch
from
8836050
to
f0324dd
Compare
pauldambra
added a commit
that referenced
this pull request
Apr 10, 2024
This reverts commit 5edead9.
timgl
pushed a commit
that referenced
this pull request
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Trying to debug in a ClickHouse query that fails before execution (internal thread), but Sentry only has the SQL before formatting with args, and it's truncated – not helpful.
Changes
We should now be capturing the full SQL.