Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(clickhouse): Capture final SQL in Sentry errors, again #21688

Merged
merged 3 commits into from
Apr 22, 2024
Merged

chore(clickhouse): Capture final SQL in Sentry errors, again #21688

merged 3 commits into from
Apr 22, 2024

Conversation

Twixes
Copy link
Collaborator

@Twixes Twixes commented Apr 19, 2024

Reverts #21479.

@Twixes
Copy link
Collaborator Author

Twixes commented Apr 19, 2024

In fairness, I only wanted to upgrade clickhouse-driver to unblock the upgrade to Py 3.11. To do that, we only need clickhouse-driver==0.2.6, and not the problematic clickhouse-driver==0.2.7. So 0.2.6 it is.

@Twixes Twixes requested a review from tomasfarias April 19, 2024 18:32
neilkakkar
neilkakkar reviewed Apr 19, 2024
View reviewed changes
.github/workflows/ci-backend.yml
- name: Checkout this PR
uses: actions/checkout@v3

- name: Install python dependencies for this PR
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also needs to run this PR's migrations, I don't think check migrations below does that

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weirdly, it should, yet it looks like it never did. 🤔 Let's add that, sure

tomasfarias
tomasfarias approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@tomasfarias tomasfarias left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with the caveat of open conversation being resolved.

@Twixes Twixes merged commit 0cf2955 into master Apr 22, 2024
98 checks passed
@Twixes Twixes deleted the revert-21479-revert-21436-capture-full-error-sql branch April 22, 2024 11:56
@mariusandra mariusandra mentioned this pull request Apr 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neilkakkar neilkakkar neilkakkar left review comments

@tomasfarias tomasfarias tomasfarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Twixes @neilkakkar @tomasfarias