feat(data-warehouse): Added a snowflake integration #22723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.06 MB ℹ️ View Unchanged
|
Gilbert09
force-pushed
the
tom/snowflake-sw
branch
from
4a234c2
to
ace3f75
Compare
EDsCODE
approved these changes
Jun 6, 2024
tomasfarias
reviewed
Jun 6, 2024
Comment on lines
153
to
159
| update_inputs = UpdateExternalDataJobStatusInputs( | ||
| id=run_id, run_id=run_id, status=ExternalDataJob.Status.COMPLETED, latest_error=None, team_id=inputs.team_id | ||
| id=run_id, | ||
| run_id=run_id, | ||
| status=ExternalDataJob.Status.COMPLETED, | ||
| latest_error=None, | ||
| team_id=inputs.team_id, | ||
| ) |
There was a problem hiding this comment.
suggestion: Should we put this in a finally to also update the status to FAILED in case an exception is raised?
tomasfarias
reviewed
Jun 6, 2024
tomasfarias
reviewed
Jun 6, 2024
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
sqlalchemydue to lack of support for newer versions in snowflake-sqlalchemy packagesqlalchemyv2+ - looking like Q4 2024 at this point (mad, I know).Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?