Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: window title plugin #24943

Merged
merged 3 commits into from
Sep 12, 2024
Merged

feat: window title plugin #24943

merged 3 commits into from
Sep 12, 2024

Conversation

daibhin
Copy link
Contributor

@daibhin daibhin commented Sep 12, 2024

Problem

Alternative approach to PostHog/posthog-js#1410

Changes

Extract the page title from snapshots using an rrweb plugin

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

With tests

@daibhin daibhin mentioned this pull request Sep 12, 2024
Closed
3 tasks
pauldambra
pauldambra approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome 🚀

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 12, 2024 •
edited
Loading

Size Change: 0 B

Total Size: 1.1 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.1 MB

compressed-size-action

@daibhin daibhin merged commit a1de415 into master Sep 12, 2024
93 checks passed
@daibhin daibhin deleted the dn-feat/window-title-plugin branch September 12, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldambra pauldambra pauldambra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daibhin @pauldambra