feat(replay): allow triggering session recording based on urls #25451
+649
−284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-better
changed the title
richard-better
force-pushed
the
richard/url-trigger
branch
from
74676ea
to
28d6248
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +56 B (0%) Total Size: 1.14 MB ℹ️ View Unchanged
|
# Conflicts: # latest_migrations.manifest
pauldambra
reviewed
Oct 14, 2024
posthog/migrations/0488_team_session_recording_url_trigger_config.py
Outdated
Show resolved
Hide resolved
frontend/__snapshots__/scenes-other-settings--settings-project-with-replay-features--dark.png
Outdated
Show resolved
Hide resolved
frontend/__snapshots__/scenes-other-settings--settings-project-with-replay-features--light.png
Outdated
Show resolved
Hide resolved
pauldambra
reviewed
Oct 14, 2024
frontend/src/scenes/settings/environment/SessionRecordingSettings.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # latest_migrations.manifest
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
richard-better
commented
Oct 17, 2024
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
# Conflicts: # frontend/__snapshots__/scenes-app-sidepanels--side-panel-docs--light.png # latest_migrations.manifest
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
pauldambra
approved these changes
Oct 17, 2024
richard-better
changed the title
richard-better
changed the title
timgl
pushed a commit
that referenced
this pull request
Oct 17, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Part of #25340
Backend and admin bits for PostHog/posthog-js#1451
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?