chore(environments): Make team.project_id officially non-null
#25597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twixes
force-pushed
the
project-id-non-null
branch
from
77addfb
to
afc88c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Team.project_idhas been de facto non-nullable since #23593. The only reason that PR couldn't officially mark it as non-nullable is that we had to go theCONSTRAINT ... NOT VALID/VALIDATE CONSTRAINTroute to avoid locking the table, so we haven't verified existing rows. In this PR we finally runVALIDATE CONSTRAINTSto complete the job.Removes the need for a bunch of pointless
team.project_id is not Noneassertions.