Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bi): Add the ability to update variables #25659

Merged
merged 9 commits into from
Oct 18, 2024
Merged

Conversation

Gilbert09
Copy link
Member

Changes

  • Update variables from the lil variable settings button
Screen.Recording.2024-10-17.at.15.13.05.mov

Does this work well for both Cloud and self-hosted?

Yeppeo

How did you test this code?

See vid ^

@Gilbert09 Gilbert09 requested a review from a team October 17, 2024 14:29
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Size Change: +149 B (+0.01%)

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.14 MB +149 B (+0.01%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Base automatically changed from tom/variable-list-type to master October 18, 2024 09:57
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Gilbert09 Gilbert09 enabled auto-merge (squash) October 18, 2024 11:24
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Gilbert09 Gilbert09 merged commit d4d5ca5 into master Oct 18, 2024
94 checks passed
@Gilbert09 Gilbert09 deleted the tom/update-variables branch October 18, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants