Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): source deletion fix #25664

Merged
merged 6 commits into from
Oct 18, 2024
Merged

fix(data-warehouse): source deletion fix #25664

merged 6 commits into from
Oct 18, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 17, 2024

Problem

  • currently, we're looping through all import jobs which is a ton

Changes

  • only focus on schemas as that's what should exist now. Loooping all jobs is redundant

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from a team October 17, 2024 17:11
@EDsCODE EDsCODE merged commit 0727c88 into master Oct 18, 2024
87 checks passed
@EDsCODE EDsCODE deleted the dw-source-deletion branch October 18, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants