Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(data-warehouse): edit source page #25668

Closed
wants to merge 9 commits into from
Closed

feat(data-warehouse): edit source page #25668

wants to merge 9 commits into from

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 17, 2024

Problem

  • can't edit sources right now

Changes

  • add this option for database based sources
Screenshot 2024-10-18 at 9 05 43 AM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE linked an issue Oct 17, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Oct 17, 2024

Size Change: 0 B

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.14 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@EDsCODE EDsCODE requested a review from a team October 18, 2024 13:05
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@EDsCODE EDsCODE removed the request for review from a team October 18, 2024 13:40
@EDsCODE EDsCODE closed this Oct 18, 2024
@EDsCODE EDsCODE deleted the dw-edit-source branch October 18, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Be able to edit managed source details
2 participants