-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(data-warehouse): edit SQL based import configs #25685
Conversation
if (source?.source_type !== 'MSSQL' && source?.source_type !== 'MySQL' && source?.source_type !== 'Postgres') { | ||
return ( | ||
<LemonBanner type="warning" className="mt-2"> | ||
<p> | ||
Only Postgres, MSSQL, and MySQL are configurable. Please delete and recreate your source if you need | ||
to connect to a new source of the same type. | ||
</p> | ||
</LemonBanner> | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this because there's not a 1:1 match between the field names and job inputs for the other sources right now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah :/
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?