Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Experiments): UX feedback from private beta of no-code experiments. #25694

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Phanatic
Copy link
Contributor

Problem

This PR addresses feedback from a private beta customer of no-code experiments.

  1. Can't tell if all transforms apply on Element selection in a variant.
  2. Allow editing variants before an experiment is launched.
  3. Cannot select SPAN & H2 elements

Changes

1Show checkbox next to icon if a transform is enabled on the HTML element
image

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

👀

Copy link
Contributor

github-actions bot commented Oct 18, 2024

Size Change: +347 B (+0.03%)

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.14 MB +347 B (+0.03%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants