Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experiments): Use a HogQL expression data warehouse setup #26650

Merged
merged 4 commits into from
Dec 6, 2024

Conversation

danielbachhuber
Copy link
Contributor

@danielbachhuber danielbachhuber commented Dec 4, 2024

See #26332

Changes

Adds the ability to use a HogQL expression for the Distinct ID or Timestamp when setting up a data warehouse table as an experiment metric:

CleanShot 2024-12-04 at 17 27 39

Also abstracts <HogQLDropdown> to a reusable component.

The backend logic doesn't quite work yet: https://posthog.slack.com/archives/C019RAX2XBN/p1733332418425019

How did you test this code?

  • Selected "HogQL Expression" and verified the component displayed as expected.
  • Clicked on the component, added an expression, and verified it appeared as expected.
  • Saved the configuration, re-opened it, and verified the expression was still in place.
  • Verified I could select a non-HogQL expression too.

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

Copy link
Contributor

@andehen andehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from a newbie's bird perspective 👍

@danielbachhuber danielbachhuber merged commit 8a11a18 into master Dec 6, 2024
100 checks passed
@danielbachhuber danielbachhuber deleted the experiments/hogql-expression branch December 6, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants