Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(experiments): Fix a couple of issues in the ASOF LEFT JOIN #26886

Merged
merged 4 commits into from
Dec 13, 2024
Merged

fix(experiments): Fix a couple of issues in the ASOF LEFT JOIN #26886

merged 4 commits into from
Dec 13, 2024

Conversation

danielbachhuber
Copy link
Contributor

See #26332

Changes

  1. Fixes issue where timestamp clause from fix(experiments): Hackily apply timestamp to ASOF LEFT JOIN #26852 isn't applied because expr.left.expr.to_hogql() is an expression (e.g. 'toDateTime(timestamp)'), not a string (e.g. 'timestamp')
  2. Properly handles 'properties.$user_id' and other values for the distinct_id field. Previously it was erroneously hardcoded to 'distinct_id'.

How did you test this code?

TDD baby!

@danielbachhuber danielbachhuber requested a review from a team December 12, 2024 23:36
@danielbachhuber danielbachhuber merged commit d4cc10e into master Dec 13, 2024
90 checks passed
@danielbachhuber danielbachhuber deleted the experiments/improve-dw-query branch December 13, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raquelmsmith raquelmsmith raquelmsmith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielbachhuber @raquelmsmith