feat(experiments): Modify test account filters for DW support #27011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26332
Reverts #26947
See https://posthog.slack.com/archives/C07PXH2GTGV/p1733936406339719
Changes
Directly modifies the test account filters in
TrendsQueryBuilder, and reverts auto-joining thepersonstable from #26947.Auto-joining the
personstable isn't the right approach because the test account filters support all sorts of property types.Instead, we'll leverage all of the existing fancy auto-joining behavior for the
eventstable by updating the properties to reference the location of theeventstable on the data warehouse table.Not all of the filter types are supported yet. I created #27012 as a follow-up.
How did you test this code?
Tests should pass.