fix(experiments): Remove most property math operations #27133
Merged
+28
−234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurajmajerik
approved these changes
Dec 23, 2024
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #26332
See #26713
Fixes #26982
Changes
Removes all property math operations except 'avg':
Our underlying statistical methodology doesn't support anything other than mean, so we can't support 'sum', 'median', 'p90', etc.
They remain in insights, however:
If someone has a previously stored property math, they'll continue to see it but won't be able to select it again if they change it:
How did you test this code?
I manually verified the UI behaviors with an existing experiment.